NYL-22: Add Contact metadata and webhook parity - #485
Merged
Conversation
AaronDDM
approved these changes
Aug 27, 2026
AaronDDM
left a comment
AaronDDM
left a comment
Contributor
There was a problem hiding this comment.
Good morning! Looks good — models, docstrings, changelog and tests all covered, and the enum already had the contact triggers so the docstring-only change there is right.
One suggestion below. Approving.
AaronDDM
approved these changes
Aug 28, 2026
AaronDDM
left a comment
AaronDDM
left a comment
Contributor
There was a problem hiding this comment.
Good morning! Re-reviewed after 6406a73.
The _build_query_params test is exactly what was missing — that's the piece that could have silently regressed. UpdateContactRequest is an alias of CreateContactRequest, so metadata covers both paths. CHANGELOG has an Unreleased entry and the docstrings cover the update semantics.
One non-blocking cross-SDK note below. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata_paircontact filteringcontact.updatedandcontact.deletedwire values and guard against unsupportedcontact.createdTest plan
/Users/zhi.q/nylas-python/.venv/bin/python -m pytest(485 passed, 3 deselected)